Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes default for input elements #771

Merged
merged 1 commit into from
Dec 14, 2017
Merged

fixes default for input elements #771

merged 1 commit into from
Dec 14, 2017

Conversation

alex-osman
Copy link
Contributor

@alex-osman alex-osman commented Nov 18, 2017

  • Fixes: Input returns empty string if defaultValue not changed #764: Input returns empty string if defaultValue not changed
  • Now the return value is initialized to the value of the input element
    • This is STILL an empty string "" if no default value is supplied
    • If default value is hello world, submitting the swal will now return hello world

image

@pkeuter
Copy link

pkeuter commented Nov 27, 2017

@alex-osman Thank you for fixing this! @t4t5 Do you think it's possible that this can be merged for the next release?

@alex-osman
Copy link
Contributor Author

bump @t4t5

@t4t5 t4t5 merged commit ab9761e into t4t5:master Dec 14, 2017
@t4t5
Copy link
Owner

t4t5 commented Dec 14, 2017

Thanks for the PR! Works well!

@bandtank
Copy link

This is still happening.

@jaspreetsinghchhabra
Copy link

The issue still exists on version 2.1.2.

@GregJArnold
Copy link

GregJArnold commented May 31, 2019

#774 reverted this code... @alex-osman, was this intentional? If so, can you (or @t4t5) re-open this and comment why the fix was backed out? If not, can you submit another PR?

@foxtrime
Copy link

same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input returns empty string if defaultValue not changed
7 participants